Exports include content that is hidden on the canvas #89

Open
opened 2026-10-13 02:28:03 +00:00 by ImBenji · 0 comments
Owner

From the engineering review on 2026-10-13.

The live painter gets _effectiveHiddenSegmentIds() (which adds hidden biarcs and the collection cascade) and a filtered visibleCanvasObjects (lib/pages/map/canvas/canvas.dart:186 and around line 907). The exporters called from lib/editor_shared/editor_core.dart:2969 get the raw hidden sets and the whole _canvasObjects list, and lib/rendering/export/export_bounds.dart takes no hidden sets at all.

Scenario: hide a reference image or text object with the eye icon, or hide a collection, then export. The hidden items appear in the PNG, SVG and PDF. On an unbounded canvas the crop also pads out to reach hidden segments and stations, which is one candidate for the crop reports in #56.

Status: confirmed by reading.

Fix sketch: compute the effective hidden sets and visible object list once (as lib/agent/view_capture.dart:60 already does for objects) and pass them to all three exporters and to computeExportBounds. Related: #55.

From the engineering review on 2026-10-13. The live painter gets `_effectiveHiddenSegmentIds()` (which adds hidden biarcs and the collection cascade) and a filtered `visibleCanvasObjects` (`lib/pages/map/canvas/canvas.dart:186` and around line 907). The exporters called from `lib/editor_shared/editor_core.dart:2969` get the raw hidden sets and the whole `_canvasObjects` list, and `lib/rendering/export/export_bounds.dart` takes no hidden sets at all. **Scenario:** hide a reference image or text object with the eye icon, or hide a collection, then export. The hidden items appear in the PNG, SVG and PDF. On an unbounded canvas the crop also pads out to reach hidden segments and stations, which is one candidate for the crop reports in #56. **Status:** confirmed by reading. **Fix sketch:** compute the effective hidden sets and visible object list once (as `lib/agent/view_capture.dart:60` already does for objects) and pass them to all three exporters and to `computeExportBounds`. Related: #55.
ImBenji added the bugarea:rendering labels 2026-10-13 02:28:03 +00:00
ImBenji added this to the Arcs & Angles project 2026-10-13 02:28:03 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: IMBENJI.NET/Metro-Map-Maker#89