Delete the unreachable move-arc reresolution branch and other dead engine code #104

Open
opened 2026-10-13 02:28:58 +00:00 by ImBenji · 0 comments
Owner

From the engineering review on 2026-10-13.

kEnableMoveArcReresolution = false leaves roughly 250 lines unreachable in lib/provider/map_data_state.dart (around lines 2721 to 2982). It also contains a latent wrong tangent around line 2853 (-other.exitTangent where the neighbour's start touches; should be -other.entryTangent), so turning the flag back on would not be safe as is.

Also dead or write-only:

  • BaseSegment.fromTangents has no callers in lib/.
  • BiarcSegment._fromJson has unused clearStartCap / clearEndCap parameters (in the uncommitted cap work).
  • The command engine checkpoints are written and never read; that one is tracked with the autosave issue.

Status: from the engine reviewer's reading; the flag and line range were not re-checked independently.

Per the refactor policy, delete rather than repair.

From the engineering review on 2026-10-13. `kEnableMoveArcReresolution = false` leaves roughly 250 lines unreachable in `lib/provider/map_data_state.dart` (around lines 2721 to 2982). It also contains a latent wrong tangent around line 2853 (`-other.exitTangent` where the neighbour's start touches; should be `-other.entryTangent`), so turning the flag back on would not be safe as is. Also dead or write-only: - `BaseSegment.fromTangents` has no callers in `lib/`. - `BiarcSegment._fromJson` has unused `clearStartCap` / `clearEndCap` parameters (in the uncommitted cap work). - The command engine checkpoints are written and never read; that one is tracked with the autosave issue. **Status:** from the engine reviewer's reading; the flag and line range were not re-checked independently. Per the refactor policy, delete rather than repair.
ImBenji added the enhancement label 2026-10-13 02:28:58 +00:00
ImBenji added this to the Arcs & Angles project 2026-10-13 02:28:58 +00:00
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: IMBENJI.NET/Metro-Map-Maker#104